Fix 13825. Create a new sorter for the completion engine . #17473
Conversation
|
Thanks for opening this pull request! Now continious integration (CI) will build Pharo with your change and run all tests. This might fail due to many reasons! Please check if your PR breaks the build or makes tests fail. Feel free to add comments to the PR. After this, before your PR can be merged it needs one or more reviews. Do not hesitate to ask people (on the Mailinglist or Discord) to help! When the CI shows no problems and there are positive reviews, your PR will be merged. |
|
Before merging this pull-request, please note that it does not changes the default strategy selected in the Pharo settings. Edit: @omarabedelkader changed the default sorter to be the |
src/NECompletion/NoSorter.class.st
Outdated
| @@ -0,0 +1,20 @@ | |||
| " | |||
| I'm a class that do nothing in the suggestion list. | |||
src/NECompletion/NoSorter.class.st
Outdated
| " | ||
| I'm a class that do nothing in the suggestion list. | ||
| I return the list created from the compltion engine. |
| { #category : 'accessing' } | ||
| CoCompletionEngineTest >> tearDown [ | ||
| super tearDown. | ||
| CompletionContext sorterClass: oldSort. |
There was a problem hiding this comment.
it's already tabed in my image ... , i don't know why it's like this here.
There was a problem hiding this comment.
@omarabedelkader Because you used 4 spaces instead of 1 tab
There was a problem hiding this comment.
right !
i think now it's fixed.
src/NECompletion/SizeSorter.class.st
Outdated
| @@ -0,0 +1,20 @@ | |||
| " | |||
| I'm a class that do sorting based on the size of the context itself. | |||
In order to fix the issue , we first implement the Sorter logic already existant (Alpahbetic and ReverseAlphabetic ) and we did also implement a new Sorter logic based on the size of the completion token.
with @ValentinBourcier @olekscode