Experimental solution for step through interpreting the full flow issue #16351 #17308

carolahp · 2024-10-21T20:10:12Z

Please do not review yet
This is an experimental solution aimed at addressing issue#16351.
In it, an unknown bytecode is used to execute step through.

This is a work in progress, results and further steps will be analized with @tesonep

For performance comparison use the following code snippet

"testClass := EnhancedStepThroughTest."
testClass := StepThroughTest.

tests := testClass suite tests.

suite := TestSuite new addTests: tests.

suite run.

(AndreasSystemProfiler new spyOn: [ 1 to: 100 do: [:i | suite run] ]) totalTime.

A change in SDL2 (libsdl-org/SDL@61cd57d) caused modifier changes to be sent as a repeat keydown with different key modifiers. This causes some keybindings to become un-typeable (For example: Cmd+Shift+W, E) because the keyup events cause these new keydown repeats with the new modifiers (for the previous example these are something like Cmd+Shift/Cmd+W/Shift+W).

…out repeat events. This feels like a hack...

- fix undo/redo cases that broke text, specially when in collaboration with the syntax highlighter - make undo/redo work on a word-by-word basis - make undo/redo restore selection and cursur when doing a replacement by paste/completion Co-authored-by: Fede Lochbaum <[email protected]>

…ugSession. These tests should be parametrized in the future. They are commited like this to ease the performance comparison between DebugSession and EnhancedDebugSession

Improvements in undo/redo

…vents Fix repeat events

…cut Editor

Remove unnecessary KM repository reset

Fix typo: change "The cyclomatic complexity is heigh" to "The cyclomatic complexity is high"

…s-editor Major update of the Keymap Descriptions to a Shortcuts Editor

…t raise an exception in the interpreter but put a new context in it with the message send taken from the Smalltalk Special Array

tesonep and others added 26 commits October 12, 2024 19:26

Using unknownBytecode to improve the step through implementation

1c93efa

Fixing critics

03b5a96

Instead of removing all repeat events just try to match with and with…

b39e71b

…out repeat events. This feels like a hack...

Rename the argument to KeyboardEvent>>#isRepeat:

73d4ec0

isRepeat is false by default for KeyboardEvent-s

10a2336

Merge 73d4ec0

596aa40

Add a test for the new behavior of the dispatcher

32472c6

Temporarily creating tests for stepping through using the EnhancedDeb…

4644c40

…ugSession. These tests should be parametrized in the future. They are commited like this to ease the performance comparison between DebugSession and EnhancedDebugSession

Merge pull request pharo-project#17305 from guillep/undo-fixes

238aaf5

Improvements in undo/redo

Merge pull request pharo-project#17301 from iglosiggio/fixup-repeat-e…

9b55ea4

…vents Fix repeat events

Major update of the Keymap Descriptions to a first version of a Short…

4de0deb

…cut Editor

Update KMDescriptionPresenter.class.st

2beea03

Remove unnecessary KM repository reset

Do not use method extensions for Commander activations

3fc240c

Updated dependencies

98c493a

Fix typo in "heigh"

742a8bb

Merge pull request pharo-project#17317 from koendehondt/gh17229

005f866

Fix typo: change "The cyclomatic complexity is heigh" to "The cyclomatic complexity is high"

Merge pull request pharo-project#17311 from hernanmd/p13-enh-shortcut…

ca55b77

…s-editor Major update of the Keymap Descriptions to a Shortcuts Editor

Merge 4644c40

e4a87e7

Adding more tests to the EnhancedDebugSession

5b99683

- Adding more tests

679822c

The Bytecode interpreter should do the same that the VM, it should no…

3422804

…t raise an exception in the interpreter but put a new context in it with the message send taken from the Smalltalk Special Array

Adding a test using a block in another process

cd6d853

Adding implementation with HaltingBlock

5d96818

Halting only if we are stepping

450b838

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experimental solution for step through interpreting the full flow issue #16351 #17308

Experimental solution for step through interpreting the full flow issue #16351 #17308

carolahp commented Oct 21, 2024

Experimental solution for step through interpreting the full flow issue #16351 #17308

Are you sure you want to change the base?

Experimental solution for step through interpreting the full flow issue #16351 #17308

Conversation

carolahp commented Oct 21, 2024