Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport to P12] Improve word-by-word text navigation + tests #17285

Open
wants to merge 3 commits into
base: Pharo12
Choose a base branch
from
Open

[Backport to P12] Improve word-by-word text navigation + tests #17285

wants to merge 3 commits into from
+208 −52

Conversation

guillep
Copy link
Member

@guillep guillep commented Oct 18, 2024

Take into account new lines when navigating through text word-by-word.
We considered many different cases, check all tests.

We got inspiration from:

textmate
vs code
several browser-based text editors

They all agree in most decisions. The differences between them at the boundary of new lines.

@MarcusDenker
Copy link
Member

There is a conflict

'''
src/Rubric-Tests/RubTextEditorTest.class.st
src/Rubric/RubTextEditor.class.st
'''

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillep @MarcusDenker