Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

16927-todo-optimization-evaluates-argument-before-receiver #16956

Open
wants to merge 1 commit into
base: Pharo13
Choose a base branch
from
Open

16927-todo-optimization-evaluates-argument-before-receiver #16956

wants to merge 1 commit into from
+16 −2

Conversation

MarcusDenker
Copy link
Member

add test and make sure that we evaluate the receiver fist in OCASTTranslator>>#emitToDo:step:

fixes #16927

@MarcusDenker
Copy link
Member Author

The decompiler needs to be fixed:

FBDDecompilerTest.testMethodWithOptimizedBlocksA
FBDDecompilerTest.testToDo2
FBDDecompilerTest.testToDo4
FBDDecompilerTest.testToDoArgumentLimitIsExpression
FBDDecompilerTest.testToDoValueLimitExpression
FBDDecompilerTest.testToDoWithMessage

@MarcusDenker MarcusDenker added the Status: Need more work The issue is nearly ready. Waiting some last bits. label Jul 26, 2024
@MarcusDenker
Copy link
Member Author

This is sadly no that simple.. I will only have time to look at this after the holidays

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecisc jecisc jecisc approved these changes

Assignees
No one assigned
Labels
Status: Need more work The issue is nearly ready. Waiting some last bits.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#to:do: optimization evaluates argument before receiver
2 participants
@MarcusDenker @jecisc