Fixes C14N, PDO.PgSQL, chr() #1066
Conversation
|
thanks @kripper |
src/Peachpie.Library/Strings.cs
Outdated
| @@ -37,6 +37,11 @@ internal static CharMap InitializeCharMap() | |||
|
|
|||
| #endregion | |||
|
|
|||
| // Helper function to change Console.OutputEncoding from PHP | |||
| public static void peachpie_set_string_encoding(string str) { | |||
There was a problem hiding this comment.
We can't just add a public function to the API like that. You can always define this method in privately your project, or we could add a configuration option for this.
There was a problem hiding this comment.
We can't just add a public function to the API like that. You can always define this method in privately your project, or we could add a configuration option for this.
The configuration options sounds good to me.
|
Can we have the PR without the change to thank you |
|
Please note that the helper method needed for working with iso-8859-1 and utf-8 at the same time, was reverted here: 2808001 We have been using this method in production for years and we really need it, since there is no other option. Having this method in our code, is also an obstacle for us to release pull requests of all other fixes that are required upstream. We don't know how to deal with this method. |
@jakubmisek here is a patch for the C14N bug.
Can you also please merge my helper function "peachpie_set_string_encoding()" which is required to change encoding and be able to work with ISO-8859-1 sources.
It won't harm the project, but will be usefull/required to work with ISO-8859-1 sources.