Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): Implement filter feature #19

Merged
merged 5 commits into from
Mar 23, 2022
Merged

feat(filter): Implement filter feature #19

merged 5 commits into from
Mar 23, 2022

Conversation

hyp3rflow
Copy link
Member

@hyp3rflow hyp3rflow commented Mar 22, 2022

image

part of #16

@hyp3rflow hyp3rflow requested a review from disjukr March 22, 2022 10:44
@hyp3rflow hyp3rflow self-assigned this Mar 22, 2022
Base automatically changed from feat/status to main March 22, 2022 10:44
@disjukr
Copy link
Member

disjukr commented Mar 22, 2022

🤔 That UI looks like it should be filtered by RPC method name.

@disjukr
Copy link
Member

disjukr commented Mar 22, 2022

There should be a search bar with a magnifying glass icon on the right tab to feel like searching in the request/response payload.

@hyp3rflow
Copy link
Member Author

hyp3rflow commented Mar 22, 2022

@disjukr I think the searching on both RequestList and RequestDetail by req/res payload is good when finding where certain value or response comes from. If you think this is unnecessary, how about separating it? like Including Req/Res feature or the Real Search feature.

There should be a search bar with a magnifying glass icon on the right tab to feel like searching in the request/response payload.

I'll implement the DetailSearch feature for search request or response payload on the RequestDetail section.

@hyp3rflow
Copy link
Member Author

@disjukr I changed for the filter to check only servicePath and rpcName. looks good to you?

@hyp3rflow hyp3rflow merged commit 8a194ae into main Mar 23, 2022
@hyp3rflow hyp3rflow deleted the feat/filter branch March 23, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants