Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST (string dtype): un-xfail string tests specific to object dtype #59433

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Aug 7, 2024

xref #54792

@jorisvandenbossche jorisvandenbossche changed the title TST: un-xfail string tests specific to object dtype TST (string dtype): un-xfail string tests specific to object dtype Aug 7, 2024
np.array([f"foo_{i}" for i in range(1000)], dtype=object),
),
(
ht.StringHashTable,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we added a hashtable for strings that didn't use Python objects. @phofl am I misremembering?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WillAyd the StringHashTable is string specific, but still takes an object dtype array with Python strings as input (it just assumes the array only contains strings, and not any random Python object)

@mroeschke mroeschke added this to the 2.3 milestone Aug 28, 2024
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Sep 28, 2024
@jbrockmendel
Copy link
Member Author

Still active

@jorisvandenbossche jorisvandenbossche added Strings String extension data type and string data and removed Stale labels Nov 4, 2024
@jorisvandenbossche jorisvandenbossche merged commit dbeeb1f into pandas-dev:main Nov 4, 2024
45 of 51 checks passed
@jorisvandenbossche
Copy link
Member

Thanks @jbrockmendel

Copy link

lumberbot-app bot commented Nov 4, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 dbeeb1f05bca199b3c1aed979e6ae72074a82243
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #59433: TST (string dtype): un-xfail string tests specific to object dtype'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-59433-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #59433 on branch 2.3.x (TST (string dtype): un-xfail string tests specific to object dtype)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche
Copy link
Member

Manual backport -> #60180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants