[Feature] Half-Pixel correction on prebuilt atlasses #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, have you tested examples/Demo/Pixel2Texel? |
|
It only breaks with pregenerated atlases. |
|
Demo has .bat files to prebuild atlasses, and if your code breaks it then it can't be merged |
…a per resource basis [Feature] compiling with -DENABLE_HPC makes true the hpc default for all pregenerated atlases
|
Ok, remade it so it doesnt break the texel2pixel demo. on any image you can now add hpc="true/false" in it's xml and it will enable/disable this correction to it. you can compile with -DFORCE_HPC and it will enable it by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets have a small texture (lets say under 10 px wide)
put it in a big atlas (1024x1024) somewhere in the middle
create a sprite with said texture and set its width to something big, maybe 500px
neigbour pixels of the atlas bleed into it
that's because the UV coords refer to the left border of the most left pixel and to the right border of the most right pixel of the texture
this pull request adresses this by imposing a halfpixel correction on AnimationFrame Generation time making the UVs point to the middle of those pixels