Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minifier): minify one child if statement expression #7230

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

7086cmd
Copy link
Contributor

@7086cmd 7086cmd commented Nov 10, 2024

Let's view the codspeed result at first.

Copy link

graphite-app bot commented Nov 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-minifier Area - Minifier C-enhancement Category - New feature or request labels Nov 10, 2024
Copy link
Contributor Author

7086cmd commented Nov 10, 2024

Copy link

codspeed-hq bot commented Nov 10, 2024

CodSpeed Performance Report

Merging #7230 will degrade performances by 41.78%

Comparing 11-10-feat_minifier_minify_one_child_if_statement_expression (4ea0205) with main (080a67b)

Summary

❌ 2 regressions
✅ 28 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 11-10-feat_minifier_minify_one_child_if_statement_expression Change
minifier[antd.js] 437.2 ms 547.8 ms -20.18%
minifier[typescript.js] 545.4 ms 936.8 ms -41.78%

@7086cmd 7086cmd force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch 2 times, most recently from 85ddb48 to f3f2f12 Compare November 10, 2024 08:46
@Boshen Boshen changed the base branch from 11-09-test_minifier_fix_minimize_condition_tests to graphite-base/7230 November 11, 2024 08:36
@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch from f3f2f12 to e9862e1 Compare November 11, 2024 08:41
@Boshen Boshen changed the base branch from graphite-base/7230 to main November 11, 2024 08:41
@Boshen Boshen force-pushed the 11-10-feat_minifier_minify_one_child_if_statement_expression branch from e9862e1 to 4ea0205 Compare November 11, 2024 08:41
@7086cmd 7086cmd marked this pull request as ready for review November 11, 2024 09:40
@7086cmd
Copy link
Contributor Author

7086cmd commented Nov 11, 2024

So we can assume it's a problem due to enabling a new peephole, same as #6698, #6266, as mentioned in #7231 (comment).

@Boshen Boshen self-requested a review November 16, 2024 13:51
@Boshen Boshen self-assigned this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants