-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace github.com/ghodss/yaml
with github.com/rockbears/yaml
#6501
Conversation
Hi, we already started to use a new yaml lib: https://github.com/rockbears/yaml that use yaml.v3 |
At the time of making this commit, the package `github.com/ghodss/yaml` is no longer actively maintained. `sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively maintained by Kubernetes SIG. Signed-off-by: Eng Zer Jun <[email protected]>
Reference: #6501 (comment) Signed-off-by: Eng Zer Jun <[email protected]>
github.com/ghodss/yaml
with sigs.k8s.io/yaml
github.com/ghodss/yaml
with github.com/rockbears/yaml
@sguiheux Please take a look again. Thank you ❤️ |
CDS Report build-all-cds#18693.0 ✘
|
CDS Report build-all-cds#18693.1 ✘
|
CDS Report build-all-cds#18693.2 ✘
|
CDS Report build-all-cds#18693.3 ✘
|
Hi @fsamin @sguiheux . I apologize for the explicit mention, but I wanted to follow up on this pull request I created some time ago. I would be grateful if you could take some time to review the changes and provide me with your feedback. If there are any specific concerns or questions you have about the changes, I am more than willing to help address them. Thank you for your time and consideration. I truly appreciate it. ❤️ |
CDS Report build-all-cds#18851.0 ✘
|
I merge that on a another branch, to fix some go.mod lines |
* refactor: replace yaml lib (#6501) * refactor: replace `github.com/ghodss/yaml` with `sigs.k8s.io/yaml` Signed-off-by: Eng Zer Jun <[email protected]> Signed-off-by: Yvonnick Esnault <[email protected]> Co-authored-by: Eng Zer Jun <[email protected]>
The package
github.com/ghodss/yaml
is no longer actively maintained. See discussion in ghodss/yaml#75 and ghodss/yaml#80.sigs.k8s.io/yaml
is a permanent fork ofgithub.com/ghodss/yaml
.The notable change is thatgithub.com/ghodss/yaml
usesgopkg.in/yaml.v2 v2.2.2
, butsigs.k8s.io/yaml
usesgopkg.in/yaml.v2 v2.4.0
. Changes can be seen here v2.2.2...v2.4.0, mostly bug fixes.EDIT: Replace
github.com/ghodss/yaml
withgithub.com/rockbears/yaml