Quick-Styleguidist-Fix & Adjusting Margins #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated palette colors and footer color * Dynamically added year for copyright, changed color for palette and footer, used useHistory for footer links * Align links in footer * Align footer text. * Remove highlight on visited * Align links vertically and removed unnecessary css * Removed unnecessary typography parent from footer * Changed all divs to box mui * Added grid to dynamically snap components for mobile devices * Align footer description in grid * Removed xs/md for grid items to auto adjust to remaining space. * Swapped order of infringement policies and privacy policy to align with figma design * Changed infringement policy to singular * Removed underline from NBJC and Out in Tech * Refactored some variable names and removed unnecessary css * Updated buttons to navlinks and added underlines to external links * Update palette to align with header PR * Added tests to expected external links. * Added history testing for internal links and tested all the links in the footer * Update Footer.test.jsx * Changed palette to hardcoded colors because palette isn't defined in jest * Refactoring tests in the style of Daniel Irvine author of Mastering React TDD * Added three more functions for test cases. * Refactored test comparisons to be more specific. * Added tests for internal links. * Added test for copyright and remaining links. * Refactored string matching test to be general usage. * Refactored some test function names to be more descriptive * Added a parent describe to tests so it's more clear what component is tested
DEV 83 2/2: Update NavBar to the new Design
Remove NULL on 2nd address line when empty
* Converted title to h1, adjusted fontSize/margins/etc to be more responsive. Title no longer wraps * Fixed bug regarding xs height not being rendered * Added width to container to allow the searchBar room to stretch * Added commented out tests as example of what I'd test
…ponsive Fix: Update search bar to be more responsive
* Removed home page logo and implemented grid with sample photos * Updated typography and images with the proper wording/images * Reorganized text and photo positioning for mobile devices * Added padding for desktop views * Added margins between text bodies and shrunk images in mobile dimensions * Added buttons and icons to homepage * Added margin between icon and button label * Abstracted icons into startIcons components * Refactored buttons into arrays * Added gaps between buttons when wrapping * Hacky workaround to changing border color to buttons * Adjusted margins for better button spacing * Added navigation functionality for discover new spaces * Added support button functionality * Added bolding to buttons * Added buttons to mobile view * Added styling to mobile view to make it more responsive * Buttons align left for medium viewpoints * Added more breakpoints to make smaller dimensions more responsive * Converted px values into rems * Added alt text to images * Refactored some of the image names * Readjusted margins for smaller dimensions * Replaced MUI grid with flexbox to fix margins * Centered body content and adjusted font size and image sizes * Enlarged buttons for larger dimensions * Aligns mobile images to be centered * Add a space now properly aligns left at all dimensions, maxWidth reduced for text containers at higher dimensions to accomdate breakpoints * Mobile images are limited to 300width to be dynamic down to 320px * Refactored a lot of variables names to be more clear and condensed redundant css * Fixed bug regarding root margins expanding bottom unintendedly * Abstracted redudant button mapping into function components * Added location button data and category button data inside their respective functions * Moved supportlink to a const variable to bypass eslint * Fixed error regarding keys in list items. * Fixed error regarding array being passed in as classname * Added some initial tests regarding images * Start of Component Refactor: Added some template functions intended to reduce redundancy * Removed mobile view and abstracted components into reusable containers * Refactored the redundant rows into one reusable component to be more DRY * Buttons and images now render properly in mobile dimensions * Moved handle click to related function. * Setting up exported components for testing environements * Added tests for button component and row text content. * Abstracted the button rows into utiliary functions * Removed support button into its own component * Added tests for buttonRow, and converted parentRowContainers into a map function * Replaced image links with image hosting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Screenshots
Ad screenshots of the changes if relevant
Before
After
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration