Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder photo with spaces that has no photo #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sereigh
Copy link

@sereigh sereigh commented Oct 12, 2021

Issue #44

  • Spaces with no imageUrl now appear with a default image in search results.
  • Spaces with no imageUrl now appear with a default image on their details page.

Added existing 404 no-text image to the repository for use as the default image.
Added conditional style to default image on the details page to prevent it from overflowing the media container.

QA Links:

Details Page
Search Results

@sereigh
Copy link
Author

sereigh commented Oct 12, 2021

Still open to review on implementation, but holding on a merge. The design team is currently creating a default image to be used.

Copy link
Contributor

@snsebro snsebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sereigh, implementation of the || operator here makes sense. Noted on the merge hold, did the design team give you an eta? If their timeline is unclear it might be ok to merge and then just change out the /web-no-image.png once they pass along the new asset. Either way looks good, thanks for getting this done!

@sereigh
Copy link
Author

sereigh commented Oct 13, 2021

Hey @sereigh, implementation of the || operator here makes sense. Noted on the merge hold, did the design team give you an eta? If their timeline is unclear it might be ok to merge and then just change out the /web-no-image.png once they pass along the new asset. Either way looks good, thanks for getting this done!

No ETA just yet, I think they meet this week. Thank you for the feedback also!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants