Compiler-Options-Hardening-Guide-for-C-and-C++.md: describe linker co… #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesamesam
force-pushed
the
linker-configure-options
branch
from
c189b74
to
34ec9d3
Compare
|
+1, looks good to me! |
thomasnyman
reviewed
Oct 3, 2024
docs/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
docs/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
docs/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.md
Outdated
Show resolved
Hide resolved
|
The group is really happy with this additional kind of material. Thank you so much!! There are some comments that need to be addressed. Let’s work it on GitHub (here), and we're okay with merging this before our next meeting if we can work out the details. |
…nfiguration options Add a section similar to "What should you do when compiling compilers?" but for linkers. LLVM doesn't accept new configure (CMake) options for default behaviour like this and instead asks distributors to use Clang configuration files, so this section is (currently) only for GNU Binutils. Per ossf#588, I've not included separate-code/rosegment, as we should handle that separately once there is consensus. Closes: ossf#623 Signed-off-by: Sam James <[email protected]>
thesamesam
force-pushed
the
linker-configure-options
branch
from
34ec9d3
to
6ebc871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiler-Options-Hardening-Guide-for-C-and-C++.md: describe linker configuration options
Add a section similar to "What should you do when compiling compilers?" but for linkers.
LLVM doesn't accept new configure (CMake) options for default behaviour like this and instead asks distributors to use Clang configuration files, so this section is (currently) only for GNU Binutils.
Per #588, I've not included separate-code/rosegment, as we should handle that separately once there is consensus.
Closes: #623
Signed-off-by: Sam James [email protected]