Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc2GitHub CWE-665 #573

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Doc2GitHub CWE-665 #573

merged 3 commits into from
Aug 20, 2024

Conversation

myteron
Copy link
Contributor

@myteron myteron commented Aug 8, 2024

As part of #531 , adding documentation to CWE-665

Copy link
Contributor

@BartyBoi1128 BartyBoi1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one comment for a missing "the" on line 22. Once this is added I will approve!

The `noncompliant01.py` code is simulating the spawning of processes with the different access rights.
The `Session(object)` class simulates access control via `User(Enum)thread` defining a `User` object to be either `GUEST = 1` (default) or `ADMIN = 2`. The `set_user()` method changes access level and `set_user_as_guest()` is to reset access.

In `SessionPool()` we spawn tasks and access control in following order:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably say "in the following order" rather than "in following order"

fixed typo

Signed-off-by: myteron <[email protected]>
Copy link
Contributor

@gkunz gkunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@myteron myteron merged commit 31cf78e into ossf:main Aug 20, 2024
2 checks passed
@myteron myteron deleted the pyCode2GitHub_CWE-665 branch August 20, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants