Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use release and tag APIs to enhance imposter commit verification #682

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

use release and tag APIs to enhance imposter commit verification #682

wants to merge 4 commits into from

Commits on Sep 23, 2024

  1. bump GitHub library to v65 

    Signed-off-by: Spencer Schrock <[email protected]>
    @spencerschrock
    spencerschrock committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    031417a View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. move githubVerifier to its own file 

    Signed-off-by: Spencer Schrock <[email protected]>
    @spencerschrock
    spencerschrock committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5b52898 View commit details
    Browse the repository at this point in the history

  2. define a commit type 

    this helps us use a map later.

Signed-off-by: Spencer Schrock <[email protected]>
    @spencerschrock
    spencerschrock committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    2f11571 View commit details
    Browse the repository at this point in the history

  3. use release and tag APIs to enhance imposter commit verification 

    The old verification process assumed a commit was always in the default
branch, or came from a select number of hardcoded release branches. This
was error prone whenever new releases branches were used by some of the
actions we check.

The commit verification workflow now uses dynamic data to determine
which branches to check. The steps are now:
1. Check if the commit is one of the latest 100 tags, which should be
   the most common case.
2. Check the default branch (unchanged from before).
3. Check branches associated with the most recent releases. This removes
   the hardcoded checks and should require fewer updates in the future.

Signed-off-by: Spencer Schrock <[email protected]>
    @spencerschrock
    spencerschrock committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c67d706 View commit details
    Browse the repository at this point in the history