Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat - Included docker-scan for the images #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naveensrinivasan
Copy link
Member

Docker scan for the image.

Copy link
Contributor

@jordan-wright jordan-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me! Left a couple of comments for consideration.

push:
pull_request:
schedule:
- cron: '0 0 * * 1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up, this appears to run at midnight every Monday - is that what you're looking to do?

docker build -t docker.pkg.github.com/ossf/package-feeds:${{ github.sha }} .

- name: Run Trivy vulnerability scanner
uses: aquasecurity/trivy-action@master
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin this to a version or commit? It's my understanding that using actions from master isn't really recommended, if possible (even though this particular one looks lower risk).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants