feeds/: Allow for per package/feed error handling when polling #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom--pollard
force-pushed
the
handle_per_package_err
branch
4 times, most recently
from
6d2d85f
to
c23cde4
Compare
tom--pollard
changed the title
|
If it's deemed necessary I can look to add this behaviour for all feeds in a single PR |
Qinusty
reviewed
Jun 3, 2021
tom--pollard
force-pushed
the
handle_per_package_err
branch
from
c23cde4
to
dcde494
Compare
Qinusty
reviewed
Jun 7, 2021
tom--pollard
force-pushed
the
handle_per_package_err
branch
from
dcde494
to
7ec66e0
Compare
tom--pollard
changed the title
tom--pollard
force-pushed
the
handle_per_package_err
branch
from
74e67a9
to
a829d21
Compare
tom--pollard
changed the title
tom--pollard
force-pushed
the
handle_per_package_err
branch
5 times, most recently
from
8c3cefe
to
28a10ec
Compare
|
@Qinusty In terms of beyond general review, I'm particularly interested in ensuring nuget/packagist are ok as it's my first time working with those feed implementations. I'm also happy to split any new tests into a separate commit once reviewed. |
Qinusty
reviewed
Jun 8, 2021
tom--pollard
force-pushed
the
handle_per_package_err
branch
2 times, most recently
from
e364346
to
b959d60
Compare
Qinusty
reviewed
Jun 10, 2021
tom--pollard
force-pushed
the
handle_per_package_err
branch
2 times, most recently
from
e42e43b
to
d79dc2a
Compare
When errors occur but package data can still be processed then the system should continue where possible. This is particularly beneficial in feeds where data is fetched on a per package basis, as a singular failure shouldn't immediately lead to data loss for the whole session. `pollAndPublish()` error handling and subsequent callers have been modified to handle this. This also removes `errUnpublished` as a 'hard' error when polling npm for critical packages as such it is only logged.
tom--pollard
force-pushed
the
handle_per_package_err
branch
from
d79dc2a
to
863aeff
Compare
Qinusty
approved these changes
Jun 11, 2021
This was referenced Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #107
Follow ups in the form of #101 and more tests/granular handling in nuget & packagist should also be undertaken