Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upstream field. #312

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add upstream field. #312

wants to merge 4 commits into from

Conversation

oliverchang
Copy link
Contributor

Fixes #249.

Fixes #249.

Signed-off-by: Oliver Chang <[email protected]>
@jasinner
Copy link
Contributor

LGTM

Copy link
Contributor

@luhring luhring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for moving this forward. 🙇

Had a few thoughts on capturing the intent from our discussion in #249, but I defer to the OSV maintainers here.

docs/schema.md Outdated
@@ -518,7 +519,26 @@ package(s). For example, if a CVE describes a vulnerability in a language
library, and a Linux distribution package contains that library and therefore
publishes an advisory, the distribution's OSV record must not list the CVE ID as
an alias. Similarly, distributions often bundle multiple upstream
vulnerabilities into a single record. `related` should be used in these cases.
vulnerabilities into a single record. `upstream` should be used in these cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think it's slightly unclear what "these cases" refers to here, since this paragraph touches on both upstream and downstream packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pointing this out. I've tweaked the wording here to make it clearer.

docs/schema.md Outdated Show resolved Hide resolved
docs/schema.md Outdated Show resolved Hide resolved
oliverchang and others added 3 commits November 20, 2024 14:14
Co-authored-by: Dan Luhring <[email protected]>
Signed-off-by: Oliver Chang <[email protected]>
Co-authored-by: Dan Luhring <[email protected]>
Signed-off-by: Oliver Chang <[email protected]>
Signed-off-by: Oliver Chang <[email protected]>
@oliverchang
Copy link
Contributor Author

Thanks for the suggestions @luhring !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that distro advisories and aliasing work well together
3 participants