evaluator.rules: Improve the copyleft in source rules #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteenbe
reviewed
Nov 17, 2022
| @@ -1071,16 +1071,9 @@ fun RuleSet.copyleftInSourceRule() = packageRule("COPYLEFT_IN_SOURCE") { | |||
| +isCopyleft() | |||
| } | |||
|
|
|||
| val message = if (licenseSource == LicenseSource.DETECTED) { | |||
There was a problem hiding this comment.
Think we should have declared and detected licenses message here.
There was a problem hiding this comment.
In line 1075 we have:
"The ScanCode 'copyleft' categorized license $license was ${licenseSource.name.lowercase()} in project " +
"${pkg.metadata.id.toCoordinates()}.",
${licenseSource.name.lowercase()} resolved to either "declared" or "detected".
So, we have it. I believe the message fits both cases. What do you think?
There was a problem hiding this comment.
So it produces
- The ScanCode 'copyleft' categorized license $license was declared in project $id."
- The ScanCode 'copyleft' categorized license $license was detected in project $id."
Signed-off-by: Frank Viernau <[email protected]>
Note: The license source is either DECLARED or DETECTED, but never CONCLUDED, because licenses can only be concluded for packages / dependencies. Signed-off-by: Frank Viernau <[email protected]>
Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
copyleft-in-source-improvements
branch
from
5390a52
to
1019e9b
Compare
tsteenbe
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Context: #66.