curations: Update curations for Nuget packages

[mnonnenmacher]

Update the curations by running the generation tasks in tools/curations.

[sschuberth]

IIRC, @fviernau did some corrections to these generated curation in #225. I hope these do not get overwritten now.

[mnonnenmacher]

IIRC, @fviernau did some corrections to these generated curation in #225. I hope these do not get overwritten now.

That's really unfortunate, why fix the generated code instead of the generator? Also, it appears to me that the "fixes" did not fix any real issues as curations for non-published packages do not do any harm except for wasting a little space.
I won't have time to go through the >200 files anytime soon.

[sschuberth]

curations for non-published packages do not do any harm

Then maybe I'm mistaken, as I recall during the review that (some of) these packages are published. @fviernau can probably tell better.

[mnonnenmacher]

IIRC, @fviernau did some corrections to these generated curation in #225. I hope these do not get overwritten now.

That's really unfortunate, why fix the generated code instead of the generator? Also, it appears to me that the "fixes" did not fix any real issues as curations for non-published packages do not do any harm except for wasting a little space. I won't have time to go through the >200 files anytime soon.

I had a look at one single package (NuGet:Microsoft.AspNetCore:Authentication) and it appears there is some problem with the generator. However, I still don't understand why this was not addressed by fixing the generator, the manual fixes probably missed many packages?

[fviernau]

@mnonnenmacher I have a hunch you do not really understand the fixes I've made, so
why judging about the approach without asking the question why? e.g.:

That's really unfortunate, why fix the generated code instead of the generator?

The effort it took to investigate the issues caused by all these wrong curations was that huge,
that I would have probably been faster if they were not existent at all.

Also, it appears to me that the "fixes" did not fix any real issues as curations for non-published packages do not do any harm except for wasting a little space.

Each of these fixes did fix any real issues, in contrast to the generated curations, where many of them seems to
have been introduced for non-real issues.

However, I still don't understand why this was not addressed by fixing the generator, the manual fixes probably missed many packages?

Because the approach how these are generated does not work, and coming up with a better approach would mean redo it from scratch.

Please, let's avoid generating more broken curations with this task.
I could help with pointing out the problems with the existing approach, if someone is willing to put effort into implemting a fix.

(A short summary of some of the fixes: Some packages have been released from multiple repositories. The fixes ensure that the vcs URL points to the repo the release has been created from, so that the SHA1 in the metadata
can be found in the repository. The generated ones did not always accomplish that).

[fviernau]

Please do not revert my fixes.