Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and improve curations for Python packages #131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tsteenbe
Copy link
Member

See individual commits for details.

Align older curations with new way of doing declared
license curations.

Improvements include:
- More elaborate proof for curations
- No URLs pointing to main or master branches

Signed-off-by: Thomas Steenbergen <[email protected]>
Comment on lines +21 to +24
"Apache Software License": "Apache-2.0 AND BSD-2-Clause AND LicenseRef-scancode-public-domain"
"BSD License": "Apache-2.0 AND BSD-2-Clause AND LicenseRef-scancode-public-domain"
"BSD, Public Domain, Apache": "Apache-2.0 AND BSD-2-Clause AND LicenseRef-scancode-public-domain"
"Public Domain": "Apache-2.0 AND BSD-2-Clause AND LicenseRef-scancode-public-domain"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these mappings shouldn't include the compound expression. ORT should be able to handle that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsteenbe, do you intend to continue working on this PR?

@brunopacheco1
Copy link
Contributor

@tsteenbe @MarcelBochtler Hello dear peeps, this is a kind reminder on this PR. We have a couple of projects failing due to PyPI packaging and it would be really great if we can reuse ort-config directly, instead of forking on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants