Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ORT_HOME_PATH/cache to the locations for the GH cache #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

netomi
Copy link

@netomi netomi commented Dec 1, 2023

Some package managers store downloaded artifacts in the ORT_HOME_PATH/cache directory for faster access after the first run, one example being the maven package manager.

Adding the .m2 directory as cache is not sufficient in this case, as the package manager will do a head request for all artifacts all the time unless it is found in the aforementioned cache.

Please ensure that your pull request adheres to our contribution guidelines. Thank you!

Some package managers stores downloaded artifacts in the ORT_HOME_PATH/cache directory for faster access after the first run, one example being the maven package manager. 

Adding the .m2 directory as cache is not sufficient in this case, as the package manager will do a head request for all artifacts all the time unless it is found in the aforementioned cache.

Signed-off-by: Thomas Neidhart <[email protected]>
@sschuberth
Copy link
Member

Is this the (only) root cause of the slowness compared to pure Maven you mentioned over here?

@netomi
Copy link
Author

netomi commented Dec 1, 2023

No that would only make subsequent runs of the action faster imho. The initial run might still be slow.
However, I am not sure if this PR makes sense atm, as I realized that the cache is initialized by default with a maxCacheEntryAgeInSeconds of 6h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants