Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add images for Jazzy testing #741

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Add images for Jazzy testing #741

merged 2 commits into from
Apr 30, 2024

Conversation

mikaelarguedas
Copy link
Contributor

@ruffsl curious to know how you feel about this.

Jazzy will be released in a month and is not fully ready yet
Having images available for pre-release would be likely useful

I was thinking of:

  • publishing these images (based on the testing apt repo) to dockerhub
    • not add them to CI
    • not move the latest tag
  • A jazzy release time:
    • regenerate the images pointing to the right repo
    • move the latest tag
    • submit to dockerhub for rebuild

What do you think?

Signed-off-by: Mikael Arguedas <[email protected]>
Signed-off-by: Mikael Arguedas <[email protected]>
Copy link
Member

@ruffsl ruffsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sounds like a nice plan! I saw your comment on the Jazzy Jalisco Testing and Tutorial Party thread, and agree it would be handy to have some jazzy docker images for folks to play with, as well as run through their own CI pipelines. Thanks for getting ahead on this!

Comment on lines +81 to +94
Tags: jazzy-ros-core, jazzy-ros-core-noble
Architectures: amd64, arm64v8
GitCommit: 543aabeed37ee905ac3737fd38ffbc9894e997db
Directory: ros/jazzy/ubuntu/noble/ros-core

Tags: jazzy-ros-base, jazzy-ros-base-noble, jazzy
Architectures: amd64, arm64v8
GitCommit: 543aabeed37ee905ac3737fd38ffbc9894e997db
Directory: ros/jazzy/ubuntu/noble/ros-base

Tags: jazzy-perception, jazzy-perception-noble
Architectures: amd64, arm64v8
GitCommit: 543aabeed37ee905ac3737fd38ffbc9894e997db
Directory: ros/jazzy/ubuntu/noble/perception
Copy link
Contributor

@sloretz sloretz Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm desktop works from the ros2-testing apt repo, and it looks like desktop_full is should work now too edit: incorrect; only desktop is installable for now.

https://repo.ros2.org/status_page/ros_jazzy_default.html?q=variant

Copy link
Contributor Author

@mikaelarguedas mikaelarguedas Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up! It was not the case when I initially opened this.
Then I'll add it to ci here so that we get the automated build / push of these images as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sloretz FYI seem that its the same as before -> the ros ign packages are not installable (both on rolling and jazzy):

5.308 The following packages have unmet dependencies:
5.389  ros-jazzy-simulation : Depends: ros-jazzy-ros-ign-bridge but it is not installable
5.389                         Depends: ros-jazzy-ros-ign-gazebo but it is not installable
5.389                         Depends: ros-jazzy-ros-ign-image but it is not installable
5.389                         Depends: ros-jazzy-ros-ign-interfaces but it is not installable
5.392 E: Unable to correct problems, you have held broken packages.
------
Dockerfile:6
--------------------
   5 |     # install ros2 packages
   6 | >>> RUN apt-get update && apt-get install -y --no-install-recommends \
   7 | >>>     ros-jazzy-simulation=0.10.0-4* \
   8 | >>>     && rm -rf /var/lib/apt/lists/*
   9 |     
--------------------

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me what is now the right place to report this type of issue.
What would you recommend @sloretz ? ros/rosdistro ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me what is now the right place to report this type of issue.
What would you recommend @sloretz ? ros/rosdistro ?

That or https://github.com/ros2/ros2

@clalancette FYI Seems like there might be an install issue with ros-jazzy-simulation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we have to land ros2/variants#42 , and then re-release. That should unblock this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

PR following the new release of the variants for jazzy: #742

@tfoote
Copy link
Contributor

tfoote commented Apr 30, 2024

Great to have this a little bit ahead of time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants