Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement conversion to arbitrary prefixes #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

implement conversion to arbitrary prefixes #17

wants to merge 2 commits into from

Conversation

PiRK
Copy link

@PiRK PiRK commented Dec 21, 2020 •
edited
Loading

This PR adds an prefix argument to the Address.cash_address method.
If not specified, it defaults to the current prefix if the object was
instantiated from string via a CashAddr, or to the "bitcoincash:" prefix if
it was instantiated from string with a legacy address.

Test plan:
python3 -m tests.test

This is a simple solution to #16

@PiRK
implement conversion to arbitrary prefixes
51dd1c5 
This commit adds an `prefix` argument to the `Address.cash_address` method.
If not specified, it defaults to the current prefix if the object was
instantiated  from string via a CashAddr, or to the "bitcoincash:" prefix if
it was instantiated from string with a legacy address.

Test plan:

python3 -m tests.test
@PiRK
Copy link
Author

PiRK commented Dec 21, 2020

It also provides a solution for issue #13:

>>> from cashaddress.convert import Address
>>> regtest_cashaddr = Address.from_string(
...     "bitcoincash:qr4pqy6q4cy2d50zpaek57nnrja7289fkskz6jm7yf"
...     ).cash_address(prefix='regtest')
>>> print(regtest_cashaddr)
regtest:qr4pqy6q4cy2d50zpaek57nnrja7289fksjm6es9se
>>>

@coveralls
Copy link

coveralls commented Dec 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 22

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 93.81%
Totals Coverage Status
Change from base Build 14: 0.7%
Covered Lines: 197
Relevant Lines: 210
💛 - Coveralls

@PiRK
Copy link
Author

PiRK commented Dec 21, 2020

I need to sort out the issue with case.

@PiRK
support uppercase prefixes
bc8d6a9 
If the users specifies an uppercase prefix, the output should be entirely
uppercase. Mixed-case prefixes are invalid.

Note that the case is not recorded in the instance, when creating an Address
from string. If the prefix is not explicitely specified and uppercase, the
output from `Address.cash_address()` will always be lowercase.

Test plan:
python3 -m tests.test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PiRK @coveralls