add AWS missing regions , add "version" to match AWS PHP SDK request requirements #190
Conversation
| 'US East (Ohio)' => 'us-east-2', | ||
| 'US East (N. Virginia)' => 'us-east-1', | ||
| 'US West (N. California)' => 'us-west-1', | ||
| 'US West (Oregon)' => 'us-west-2', | ||
| 'Africa (Cape Town)' => 'af-south-1', | ||
| 'Asia Pacific (Mumbai)' => 'ap-south-1', | ||
| 'Asia Pacific (Osaka-Local)' => 'ap-northeast-3', | ||
| 'Asia Pacific (Seoul)' => 'ap-northeast-2', | ||
| 'Asia Pacific (Singapore)' => 'ap-southeast-1', | ||
| 'Asia Pacific (Sydney)' => 'ap-southeast-2', | ||
| 'Asia Pacific (Tokyo)' => 'ap-northeast-1', | ||
| 'Canada (Central)' => 'ca-central-1', | ||
| 'China (Beijing)' => 'cn-north-1', | ||
| 'China (Ningxia)' => 'cn-northwest-1', | ||
| 'Europe (Frankfurt)' => 'eu-central-1', | ||
| 'Europe (Ireland)' => 'eu-west-1', | ||
| 'Europe (London)' => 'eu-west-2', | ||
| 'Europe (Milan)' => 'eu-south-1', | ||
| 'Europe (Paris)' => 'eu-west-3', | ||
| 'Europe (Stockholm)' => 'eu-north-1', | ||
| 'Middle East (Bahrain)' => 'me-south-1', | ||
| 'South America (São Paulo)' => 'sa-east-1', |
There was a problem hiding this comment.
The associations will have to be reversed. That is - 'ap-south-1' => 'Asia Pacific (Mumbai)', etc.
| if ($config['verion']) | ||
| $credentials['verion'] = $config['verion']; |
| )), | ||
| 'version' => new ChoiceField(array( | ||
| 'label' => $__('AWS SDK version'), | ||
| 'version' => array( |
There was a problem hiding this comment.
This array needs to be named 'choices'
There was a problem hiding this comment.
In addition to these changes, I had to do a few more to get the plugin to work. The AWS SDK needs to be updated to 3.x, and that necessitates changes in plugin.php, as well as additional requires in both config.php and storage.php to load namespace functions.
Finally, in the constructor in storage.php, the config values for 'region' and 'version' aren't getting picked up (even after changing the spelling from 'verion') in Admin > Settings > System > Attachments Storage and Settings, after configuring the plugin.
I am unable to update this PR myself because I haven't yet figured out how to solve the issues above without hard-coding a few things in my setup.
No description provided.