Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update make.php #103

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update make.php #103

wants to merge 1 commit into from

Conversation

ShaneOss
Copy link

Need to quote PHP_BINARY's that have spaces e.g. on Windows PHP installations performed by Web Platform Installer.

Need to quote PHP_BINARY's that have spaces e.g. on Windows PHP installations performed by Web Platform Installer.
@ntozier
Copy link
Contributor

ntozier commented May 10, 2016

I agree with you that it should escape the string in general but in the interim couldn't you instead of:
X:\Program Files (x86)\php\etc
use:
X:\progra~2\php\etc

@ShaneOss
Copy link
Author

Yep guess you could use the 8.3 filename and hard code it into the file. This would just alleviate that process. Was just thinking from a continual improvement perspective and to save others troubleshooting the "'C:\Program' is not recognized as an internal or external command, operable program or batch file." error. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants