Log out after system is registered #20712
Conversation
pdostal
commented
Nov 29, 2024
•
pdostal
commented
- Related ticket: poo#170356
- Verification run: SLES, SAP
pdostal
requested review from
grisu48,
asmorodskyi,
ricardobranco777,
mpagot,
m-dati,
alvarocarvajald,
BillAnastasiadis and
rbmarliere
as code owners
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
I think some other different types of VRs are needed here, like SAP too 🙂. |
| @@ -116,6 +116,7 @@ sub registercloudguest { | |||
| # Check what version of registercloudguest binary we use | |||
| $instance->ssh_script_run(cmd => "rpm -qa cloud-regionsrv-client"); | |||
| $instance->ssh_script_retry(cmd => "sudo $suseconnect -r $regcode", timeout => 420, retry => 3, delay => 120); | |||
| assert_script_run('ssh -O exit ' . $instance->username . '@' . $instance->public_ip); | |||
There was a problem hiding this comment.
I think we need to do this on every console that is opened.
There was a problem hiding this comment.
I think your suggestion applies only to TUNNELED=1 tests. But even in those we don't (re)register the system after publiccloud/ssh_interactive_start test module.
The publiccloud::utils::registercloudguest subroutine is currently used in the following test modules:
publiccloud/registrationpubliccloud/migrationpubliccloud/slem_basicpubliccloud/run_ltppubliccloud/check_registercloudguestpubliccloud/storage_perfsles4sap/publiccloud/qesap_terraformsles4sap/cloud_netconfig/deploy
I think think that we are safe. But please feel free to suggest more VRs.
|
@m-dati SAP VR done (see the description). |
