Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTP: Allow to reboot after each test (LTP_REBOOT_AFTER_TEST=1) #20689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pevik
Copy link
Contributor

@pevik pevik commented Nov 27, 2024

Add LTP_REBOOT_AFTER_TEST=1 variable to allow to reboot after each test (needed for certain tests, e.g. IMA).

Related ticket: https://progress.opensuse.org/issues/159045

Verification run:

@pevik pevik requested review from czerw and mdoucha November 27, 2024 08:59
@czerw
Copy link
Contributor

czerw commented Nov 27, 2024

Do we need reboot even for skipped tests https://openqa.suse.de/tests/16025349#step/ima_keys/12 ?

@czerw czerw changed the title LTP: Allow to reboot after each test (LTP_REBOOT_AFTER_TEST=1) [WIP] LTP: Allow to reboot after each test (LTP_REBOOT_AFTER_TEST=1) Nov 28, 2024
@czerw czerw marked this pull request as draft November 28, 2024 09:39
@czerw czerw changed the title [WIP] LTP: Allow to reboot after each test (LTP_REBOOT_AFTER_TEST=1) LTP: Allow to reboot after each test (LTP_REBOOT_AFTER_TEST=1) Nov 28, 2024
@pevik pevik force-pushed the LTP_REBOOT_AFTER_TEST branch 13 times, most recently from a0cf8a4 to 0878788 Compare November 29, 2024 06:27
@pevik
Copy link
Contributor Author

pevik commented Nov 29, 2024

Do we need reboot even for skipped tests https://openqa.suse.de/tests/16025349#step/ima_keys/12 ?

Good point, thanks! Solved by checking if return value != 32 (TCONF).
https://openqa.suse.de/tests/16048765#step/ima_keys/7

@pevik pevik marked this pull request as ready for review November 29, 2024 06:47
@pevik pevik marked this pull request as draft November 29, 2024 07:00
@pevik pevik force-pushed the LTP_REBOOT_AFTER_TEST branch 4 times, most recently from ee06b4c to d8bf631 Compare November 29, 2024 08:49
Add LTP_REBOOT_AFTER_TEST to allow to reboot after each test.
This will be used for IMA testing (ltp_ima_reboot).

Link: poo#159045
Signed-off-by: Petr Vorel <[email protected]>
@pevik pevik marked this pull request as ready for review November 29, 2024 09:58
@pevik
Copy link
Contributor Author

pevik commented Nov 29, 2024

Rewritten detection of the last test (it did not work when LTP_COMMAND_EXCLUDE contained the latest item. I suspect it will not work when the latest item has skip in the yaml file, but I consider that minor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants