-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for chocolate-doom #20661
base: master
Are you sure you want to change the base?
Add test for chocolate-doom #20661
Conversation
doom was mentioned during a common criteria auditing meeting at SUSE as a fun side-note but I am also taking those seriously.
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only testing the chocolate-doom launcher - doesn't actually run/test doom
and you would need to get written permission to add a wad file (unless you make your own)
I am also taking those seriously.
Perhaps too seriously :)
Also leave it only on development jobgroups.
Yes, this is only testing the chocolate-doom launcher which is the essential part of the package. I don't see that as a hindrance.
Why should we? I verified the test and don't see a need to stabilize further in a development job group. |
It isn't a hinderance, the test is incomplete. The error message you get, is way before anything besides default configuration is loaded: https://github.com/chocolate-doom/chocolate-doom/blob/bb9bb2324852db731d81ee8c1f16a9b0b0fc31df/src/doom/d_main.c#L1496
See above. The test isn't necessarily unstable, but is not testing any functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
it does :
ofc. it is very minimal set , but correct me if I am wrong it is more then we have in master today , right ? |
P.S. in case you wonder what I am doing in this PR , it is very simple I got caught by PR name :D |
doom was mentioned during a common criteria auditing meeting at SUSE as a fun side-note but I am also taking those seriously.
Verification run: https://openqa.opensuse.org/tests/4658592