Refactor code for offline host ugprade #20617
Open
+26
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waynechen55
force-pushed
the
wayne/bsc#1231522_sles15sp7_offline_upgrade_remove_rebootnow
branch
8 times, most recently
from
2c66b2f
to
8a9e793
Compare
waynechen55
force-pushed
the
wayne/bsc#1231522_sles15sp7_offline_upgrade_remove_rebootnow
branch
6 times, most recently
from
67c6af7
to
edf059e
Compare
|
@alice-suse @guoxuguang @Julie-CAO @RoyCai7 @nanzhg @tbaev Please have a look. |
waynechen55
force-pushed
the
wayne/bsc#1231522_sles15sp7_offline_upgrade_remove_rebootnow
branch
2 times, most recently
from
9245574
to
4ff49fa
Compare
Due to drastic change introduced by bsc#1231522, code for offline host upgrade test scenario needs to be refactored to suit this new situation in which first stage upgrade will be performed directly on ipmi sol console to save unnecessary needle match and function check_port_state will be used to detect whether upgrade process finishes or not continuously.
waynechen55
force-pushed
the
wayne/bsc#1231522_sles15sp7_offline_upgrade_remove_rebootnow
branch
from
4ff49fa
to
9a23506
Compare
|
Let's wait for reply to https://bugzilla.suse.com/show_bug.cgi?id=1231522#c33, then we will know if rebootnow kept or not in product manager's opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to drastic change introduced by bsc#1231522, code for offline host upgrade test scenario needs to be refactored to suit this new situation.
The whole process of offline host upgrade will be performed automatically on ipmi sol console to save unnecessary needle match.
Skip system reboot after
UPGRADE_AFTER_REBOOT, because it will interrupt ongoing offline host upgrade.Function
check_port_statewill be used to detect whether upgrade process finishes or not continuously.By the way, if
reboot nowdialogue comes back in the future, its assertion can still be added in based on this pull request. This pull request cleans things up and make the overall process more clear and neat anyway.Verification Runs: