Add test for Sap Business One Installation #20442
Open
+399
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emiura
requested review from
a-kpappas,
alvarocarvajald,
Amrysliu,
BillAnastasiadis,
jankohoutek,
lilyeyes,
lpalovsky and
mpagot
as code owners
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
emiura
force-pushed
the
bone
branch
2 times, most recently
from
65aa1b3
to
24322a8
Compare
emiura
force-pushed
the
bone
branch
9 times, most recently
from
9357d67
to
95b5d3e
Compare
emiura
force-pushed
the
bone
branch
2 times, most recently
from
8b9dc1f
to
a45ebc3
Compare
alvarocarvajald
approved these changes
Dec 4, 2024
mpagot
reviewed
Dec 4, 2024
| The media location must be provided as ASSET_0 in the job settings and be | ||
| available as an uncompressed tar in the factory/other directory of the openQA | ||
| server | ||
|
|
There was a problem hiding this comment.
Not a request to change just an idea: other library are documenting each argument individually
mpagot
reviewed
Dec 4, 2024
mpagot
reviewed
Dec 4, 2024
mpagot
reviewed
Dec 4, 2024
mpagot
reviewed
Dec 4, 2024
mpagot
reviewed
Dec 4, 2024
| @@ -164,7 +127,7 @@ sub run { | |||
| # If the ASSET_0 variable is defined, the test will attempt to download | |||
| # the HANA media from the factory/other directory of the openQA server. | |||
| record_info "Dowloading using ASSET_0"; | |||
| download_hana_assets_from_server(target => $target, nettout => $tout); | |||
| $self->download_hana_assets_from_server(target => $target, nettout => $tout); | |||
There was a problem hiding this comment.
was a bug present in the existing code? Is it related to newly added code in this PR?
There was a problem hiding this comment.
No, I have moved the sub from hana_install.pm to lib/sles4sap.pm as it is used on bone_install.pm as well.
Fixes TEAM-9660 Adds: Settings for b1 validation app Shell script to parse business one validation program Business One configuration file for Installation Changed to create directory only if was not preset (prevent error during mkdir /sapinst) Schedule for bone_test and bone_validation Business One Installation test Business one installation validation test Install additional modules and packages if business one installation Moved download_hana_assets_from_server to lib/sles4sap.pm Merged fixes proposed by Alvaro, Michelle and Lumir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TEAM-9660
Adds:
Settings for b1 validation app
Shell script to parse business one validation program
Business One configuration file for Installation
Changed to create directory only if was not preset (prevent error during mkdir /sapinst)
Schedule for bone_test and bone_validation
Business One Installation test
Business one installation validation test
Install additional modules and packages if business one installation
VR:
SLE15SP4:
https://openqaworker15.qa.suse.cz/tests/305283
https://openqaworker15.qa.suse.cz/tests/305284
SLE15SP5:
https://openqaworker15.qa.suse.cz/tests/305276
https://openqaworker15.qa.suse.cz/tests/305277