-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mergify configuration #141
base: master
Are you sure you want to change the base?
Conversation
Looks like zypper crashes due to an unhandled C++ exception:
I suppose this could be considered a zypper bug. |
No, it's https://bugzilla.opensuse.org/show_bug.cgi?id=1190670 . Fixed in 3ae3006 |
8c6e690
to
fd03d48
Compare
meh, "Package 'python3-black' not found." in Leap 15.3 |
Right, I only added it recently to |
to be fixed in #142 |
Rebased, refreshed, updated, verified. All ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the approval requirement to members of @os-autoinst/asset-sync-and-integration
I don't think that's possible according to https://docs.mergify.com/workflow/actions/merge/ . Also I don't think that we need to overcomplicate things. Still only approvals from priviledged members of the organisation count, not like anybody |
Not convinced. Ever heard of bad actors and account takeover? - If others (non members of @os-autoinst/tools-team) agree, and number of approvals is increased to 2 and I can reconsider. I am not a fan of automated merges on things that go live - also no description is provided nor reasoning as to why is it important for this repository. |
Sure, let's play it safe(r). Increased to >=2 now.
Well, first it might seem to be more convenient than it is important but we have good experiences in os-autoinst, openQA and others and the approach is helping to improve the quality and prevent unforeseen problems because unlike human reviewers mergify is very diligent to ensure that all necessary CI checks are not failed but also present as happened multiple times that CI checks were not triggered at all. |
No description provided.