Make 'Broken' workers show as 'Unavailable' instead #6073
Conversation
| @@ -767,7 +767,8 @@ sub _check_system_utilization ( | |||
| return undef unless $threshold && @$load >= 3; | |||
| # look at the load evolution over time to react quick enough if the load | |||
| # rises but accept a falling edge | |||
| return "The average load (@$load) is exceeding the configured threshold of $threshold." | |||
| return | |||
| "The average load (@$load) is exceeding the configured threshold of $threshold. The worker will temporarily not accept new jobs until the load is lower again." | |||
There was a problem hiding this comment.
one comment quite off the PR. this seems to be displayed as a info next to the status. I wonder why we do not display the load as another key:value field in the page.
There was a problem hiding this comment.
you're right that might be a good idea 👍
There was a problem hiding this comment.
not sure. Maybe check with others too. for me makes sense but maybe there is a reason
There was a problem hiding this comment.
The load is not checked every time the worker details page is shown. The worker sends this info via websocket if the load is too high, and it gets saved into the worker table in the database.
r-richardson
force-pushed
the
164084_high_load_improve_wording
branch
3 times, most recently
from
b45a245
to
7a7a74d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6073 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 395 395
Lines 39508 39508
=======================================
Hits 39108 39108
Misses 400 400 ☔ View full report in Codecov by Sentry. |
r-richardson
force-pushed
the
164084_high_load_improve_wording
branch
from
7a7a74d
to
93d89ff
Compare
This commit displays "Broken" workers as instead "Unavailable", as the previous wording was e.g. not including workers which where unavailable due to 'too high load'. For the same reason the 'Error' title of the worker states hover popup is replaced with 'Details' and the 'too high load' output is enhanced. Related Ticket: https://progress.opensuse.org/issues/164084
r-richardson
force-pushed
the
164084_high_load_improve_wording
branch
from
93d89ff
to
bff1577
Compare
This PR displays "Broken" workers as instead "Unavailable", as the previous wording was e.g. not including workers which where unavailable due to 'too high load'.
It also replaces the 'Error' title of the worker states hover popup with 'Details' and enhances the 'too high load' output.
Example:
Related Ticket: https://progress.opensuse.org/issues/164084