-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test codes #228
Open
seban999
wants to merge
10
commits into
master
Choose a base branch
from
testing-cache-improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test codes #228
Commits on Sep 29, 2016
-
Refactor getter caching based on keypath state
The current version of NuclearJS uses a cache key consisting of store states (monotomically incresing ID per store). This has the disadvantage of allowing only a single level of depth when figuring out if a cache entry is stale. This leads to poor performance when the shape of a Reactor's state is more deep than wide, ie a store having multiple responsibilities for state tracking. The implementation is as follows: - Consumer can set the maxCacheDepth when instantiating a reactor - Getters are broken down into the canonical set of keypaths based on the maxCacheDepth - Add a keypath tracker abstraction to maintain the state value of all tracked keypaths - After any state change (`Reactor.__notify`) dirty keypaths are resolved and then based on which keypaths have changed any dependent observers are called
Configuration menu - View commit details
-
Copy full SHA for e6338d9 - Browse repository at this point
Copy the full SHA e6338d9View commit details
Commits on Sep 30, 2016
-
Improve cleaning phase of keypath tracker cache
Instead of doing a full recursive traversal of the keypathStates tree, keep track of all changed paths as use that as an indicator of the paths the need to be cleaned
Configuration menu - View commit details
-
Copy full SHA for 284b003 - Browse repository at this point
Copy the full SHA 284b003View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1184c03 - Browse repository at this point
Copy the full SHA 1184c03View commit details
Commits on Oct 1, 2016
-
Configuration menu - View commit details
-
Copy full SHA for e90a721 - Browse repository at this point
Copy the full SHA e90a721View commit details
Commits on Oct 2, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 2d6865f - Browse repository at this point
Copy the full SHA 2d6865fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d3ac490 - Browse repository at this point
Copy the full SHA d3ac490View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc2ccb7 - Browse repository at this point
Copy the full SHA cc2ccb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 254f18d - Browse repository at this point
Copy the full SHA 254f18dView commit details -
Configuration menu - View commit details
-
Copy full SHA for abf3c2b - Browse repository at this point
Copy the full SHA abf3c2bView commit details
Commits on Oct 3, 2016
-
Configuration menu - View commit details
-
Copy full SHA for ad79f4c - Browse repository at this point
Copy the full SHA ad79f4cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.