Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching Abstraction #211

Merged
merged 8 commits into from
Feb 6, 2016
Merged

Caching Abstraction #211

merged 8 commits into from
Feb 6, 2016

Commits on Jan 31, 2016

  1. Configuration menu
    Copy the full SHA
    ae66da7 View commit details
    Browse the repository at this point in the history
  2. Add caching abstraction

    Introduce a functional caching abstraction. The purpose is to provide extensible
    API with abstractions that are composable. Includes implementations for basic
    cache strategy (current) and an LRU cache (which wraps BasicCache).
    
    A custom caching strategy can be injected via Reactor constructor.
    
    All existing caching behavior remains the same (for now).
    loganlinn committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    90ea034 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    137bfd6 View commit details
    Browse the repository at this point in the history
  4. Replace OrderedMap with OrderedSet

    We weren't using notion of monoatomically increasing tick in LRU cache because
    an OrderedMap does not re-order exising items that are set(), so we depend on
    remove()+set(). This means the value of OrderedMap isn't used and simplifies to
    OrderedSet.
    loganlinn committed Jan 31, 2016
    Configuration menu
    Copy the full SHA
    ba8b64b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2016

  1. Don't create new LRUCache when not needed

    If you call hit() on an item that's not actually in the LRUCache (edge case),
    it's a no-op, so we can just return this.
    loganlinn committed Feb 2, 2016
    Configuration menu
    Copy the full SHA
    bfcb9a1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3a4eafb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2eefde8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4fb6b8c View commit details
    Browse the repository at this point in the history