-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caching Abstraction #211
Merged
Merged
Caching Abstraction #211
Commits on Jan 31, 2016
-
Configuration menu - View commit details
-
Copy full SHA for ae66da7 - Browse repository at this point
Copy the full SHA ae66da7View commit details -
Introduce a functional caching abstraction. The purpose is to provide extensible API with abstractions that are composable. Includes implementations for basic cache strategy (current) and an LRU cache (which wraps BasicCache). A custom caching strategy can be injected via Reactor constructor. All existing caching behavior remains the same (for now).
Configuration menu - View commit details
-
Copy full SHA for 90ea034 - Browse repository at this point
Copy the full SHA 90ea034View commit details -
Configuration menu - View commit details
-
Copy full SHA for 137bfd6 - Browse repository at this point
Copy the full SHA 137bfd6View commit details -
Replace OrderedMap with OrderedSet
We weren't using notion of monoatomically increasing tick in LRU cache because an OrderedMap does not re-order exising items that are set(), so we depend on remove()+set(). This means the value of OrderedMap isn't used and simplifies to OrderedSet.
Configuration menu - View commit details
-
Copy full SHA for ba8b64b - Browse repository at this point
Copy the full SHA ba8b64bView commit details
Commits on Feb 2, 2016
-
Don't create new LRUCache when not needed
If you call hit() on an item that's not actually in the LRUCache (edge case), it's a no-op, so we can just return this.
Configuration menu - View commit details
-
Copy full SHA for bfcb9a1 - Browse repository at this point
Copy the full SHA bfcb9a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a4eafb - Browse repository at this point
Copy the full SHA 3a4eafbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2eefde8 - Browse repository at this point
Copy the full SHA 2eefde8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4fb6b8c - Browse repository at this point
Copy the full SHA 4fb6b8cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.