Allow all debug options to be flagged on / off as overrides #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! 👍 Thanks @jordangarcia, looks awesome |
| @@ -11,24 +20,31 @@ exports.dispatchStart = function(type, payload) { | |||
| } | |||
| } | |||
|
|
|||
| exports.dispatchError = function(error) { | |||
| exports.dispatchError = function(reactorState, error) { | |||
| console.log('dispatchError, shoud do', getOption(reactorState, 'logDispatches')) | |||
|
Minor nits, but LGTM! 👍 |
Update API docs with new options
|
I updated this to always be true for debug and false for non debug. Can you take a final look @bhamodi |
|
Yup, changes look good. Just the minor nits left to address @jordangarcia. |
jordangarcia
added a commit
that referenced
this pull request
Dec 23, 2015
Allow all debug options to be flagged on / off as overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#178 @iansinnott