Fix bug where cache didn't update dirty entries

optimizely · Feb 2, 2016 · 4fb6b8c · 4fb6b8c
1 parent 2eefde8
commit 4fb6b8c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/src/reactor/fns.js b/src/reactor/fns.js
@@ -334,8 +334,8 @@ export function evaluate(reactorState, keyPathOrGetter) {
 
   const cache = reactorState.get('cache')
   var cacheEntry = cache.lookup(keyPathOrGetter)
-  const isCacheMiss = !cacheEntry
-  if (isCacheMiss || isDirtyCacheEntry(reactorState, cacheEntry)) {
+  const isCacheMiss = !cacheEntry || isDirtyCacheEntry(reactorState, cacheEntry)
+  if (isCacheMiss) {
     cacheEntry = createCacheEntry(reactorState, keyPathOrGetter)
   }
 

diff --git a/tests/reactor-tests.js b/tests/reactor-tests.js
@@ -595,6 +595,24 @@ describe('Reactor', () => {
         expect(taxPercentSpy.calls.count()).toEqual(2)
         expect(subtotalSpy.calls.count()).toEqual(1)
       })
+
+      it('should update cache with updated item after action', () => {
+        const lastItemGetter = [['items', 'all'], (items) => items.last()]
+
+        // ensure its in cache
+        const lastItemBefore = reactor.evaluate(lastItemGetter)
+        const cacheEntryBefore = reactor.reactorState.cache.lookup(lastItemGetter)
+        expect(lastItemBefore === cacheEntryBefore.value).toBe(true)
+
+        checkoutActions.addItem('potato', 0.80)
+
+        const lastItemAfter = reactor.evaluate(lastItemGetter)
+        const cacheEntryAfter = reactor.reactorState.cache.lookup(lastItemGetter)
+        expect(lastItemAfter === cacheEntryAfter.value).toBe(true)
+
+        // sanity check that lastItem actually changed for completeness
+        expect(lastItemAfter !== lastItemBefore).toBe(true)
+      })
     })
 
     describe('#observe', () => {