Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix some nat traversal bugs #141

Closed
wants to merge 1 commit into from

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Nov 7, 2023

No description provided.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 157 lines in your changes are missing coverage. Please review.

Comparison is base (bee0a5d) 40.89% compared to head (332eabf) 37.72%.
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/networkengine/vpndriver/libreswan/libreswan.go 36.02% 106 Missing and 13 partials ⚠️
pkg/utils/stun.go 9.67% 28 Missing ⚠️
pkg/networkengine/vpndriver/driver.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
- Coverage   40.89%   37.72%   -3.18%     
==========================================
  Files           9       10       +1     
  Lines        1137     1275     +138     
==========================================
+ Hits          465      481      +16     
- Misses        582      697     +115     
- Partials       90       97       +7     
Flag Coverage Δ
unittests 37.72% <30.83%> (-3.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YTGhost YTGhost force-pushed the fix-lint-and-ut branch 3 times, most recently from d65e5d0 to 44a54be Compare November 7, 2023 13:02
@YTGhost YTGhost marked this pull request as draft November 7, 2023 13:21
@YTGhost YTGhost marked this pull request as ready for review November 16, 2023 10:37
@YTGhost
Copy link
Member Author

YTGhost commented Nov 16, 2023

@BSWANG @njucjc @River-sh PTAL

@River-sh
Copy link
Contributor

A switch should be provided in boot options to enable or disable nat traversal

@YTGhost
Copy link
Member Author

YTGhost commented Nov 17, 2023

A switch should be provided in boot options to enable or disable nat traversal

ok, I'll add this switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants