fix boot mode for raven agent #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
River-sh
commented
Oct 9, 2023
•
River-sh
commented
- raven agent container can not get args configured in yaml if using shell (raven.sh)
- rename component name for edge-hub to persist informer cache
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
=======================================
Coverage 42.69% 42.69%
=======================================
Files 7 7
Lines 1089 1089
=======================================
Hits 465 465
Misses 534 534
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more. |
River-sh
force-pushed
the
fix_dockerfile
branch
4 times, most recently
from
26a7b0f
to
ef681af
Compare
|
Can you describe the background of the modification? |
River-sh
changed the title
River-sh
force-pushed
the
fix_dockerfile
branch
from
ef681af
to
7886616
Compare
|
njucjc
reviewed
Oct 9, 2023
| ENTRYPOINT raven.sh | ||
| ENTRYPOINT ["/usr/local/bin/raven-agent-ds"] |
There was a problem hiding this comment.
how to pass args to raven-agent-ds
There was a problem hiding this comment.
how to pass args to raven-agent-ds
args is automatically appended to this command “/usr/local/bin/raven-agent-ds”
There was a problem hiding this comment.
args cannot be passed in boot commands if ENTRYPOINT executes script
There was a problem hiding this comment.
ENTRYPOINT raven.sh
afaik this line ^ will be ignored?
njucjc
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.