Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support raven l7 #134

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

River-sh
Copy link
Contributor

@River-sh River-sh commented Oct 8, 2023

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #134 (59daf2d) into main (7886616) will decrease coverage by 1.81%.
Report is 4 commits behind head on main.
The diff coverage is 6.77%.

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   42.69%   40.89%   -1.81%     
==========================================
  Files           7        9       +2     
  Lines        1089     1137      +48     
==========================================
  Hits          465      465              
- Misses        534      582      +48     
  Partials       90       90              
Flag Coverage Δ
unittests 40.89% <6.77%> (-1.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/networkengine/vpndriver/driver.go 64.81% <ø> (ø)
pkg/networkengine/routedriver/vxlan/utils.go 40.51% <0.00%> (ø)
pkg/networkengine/routedriver/vxlan/vxlan.go 57.94% <33.33%> (ø)
pkg/types/network.go 5.88% <0.00%> (ø)
pkg/networkengine/vpndriver/libreswan/libreswan.go 45.55% <50.00%> (-0.17%) ⬇️
pkg/utils/metaserver.go 0.00% <0.00%> (ø)
pkg/utils/utils.go 0.00% <0.00%> (ø)

@River-sh River-sh force-pushed the featrue/support_raven_l7 branch 12 times, most recently from 317b9a3 to 6026c2e Compare October 8, 2023 08:36
@njucjc
Copy link
Member

njucjc commented Oct 9, 2023

Please fix the docker build action error

@River-sh River-sh force-pushed the featrue/support_raven_l7 branch 7 times, most recently from 58d5bca to 40316fa Compare October 11, 2023 12:56
cmd/agent/app/start.go Outdated Show resolved Hide resolved
@njucjc njucjc self-requested a review October 12, 2023 08:54
@River-sh River-sh force-pushed the featrue/support_raven_l7 branch 3 times, most recently from f0ea179 to 1177b9d Compare October 12, 2023 11:06
@@ -561,29 +486,3 @@ func parseSubnets(subnets []string) []net.IPNet {
}
return nets
}

func (w *wireguard) ensureRavenSkipNAT(centralGw *types.Endpoint, connection *vpndriver.Connection) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete this function?

Copy link
Contributor Author

@River-sh River-sh Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems I missed the commit 221a303,I has fix it

@River-sh River-sh force-pushed the featrue/support_raven_l7 branch 2 times, most recently from 15649d2 to 498f7cc Compare October 13, 2023 03:07
Copy link
Member

@luckymrwang luckymrwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@njucjc njucjc merged commit 3197c5d into openyurtio:main Oct 20, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants