Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Use -fno-canonical-system-headers for gcc #19691

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Open

[ROCm] Use -fno-canonical-system-headers for gcc #19691

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ffd8a4
Use -fno-canonical-system-headers for gcc
alekstheod Nov 22, 2024
de93107
Merge branch 'main' into ci_use_fn_no_canonical_system_headers_for_gc…
alekstheod Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions third_party/tsl/third_party/gpus/crosstool/clang/bin/crosstool_wrapper_driver_rocm.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import pipes

# Template values set by rocm_configure.bzl.
CPU_COMPILER = ('%{cpu_compiler}')
USE_CLANG = ('%{compiler}' == 'clang')
HOST_COMPILER_PATH = ('%{host_compiler_path}')

HIPCC_PATH = '%{hipcc_path}'
Expand Down Expand Up @@ -261,6 +262,8 @@ def main():
# this).
cpu_compiler_flags = [flag for flag in sys.argv[1:]
if not flag.startswith(('--rocm_log'))]
if not USE_CLANG:
cpu_compiler_flags.append('-fno-canonical-system-headers')

# XXX: SE codes need to be built with gcc, but need this macro defined
cpu_compiler_flags.append("-D__HIP_PLATFORM_HCC__")
Expand Down