-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luci-app-upnp: Finalise changes for OpenWrt 24.10 release #7407
base: master
Are you sure you want to change the base?
luci-app-upnp: Finalise changes for OpenWrt 24.10 release #7407
Conversation
applications/luci-app-upnp/htdocs/luci-static/resources/view/upnp/upnp.js
Outdated
Show resolved
Hide resolved
applications/luci-app-upnp/htdocs/luci-static/resources/view/upnp/upnp.js
Outdated
Show resolved
Hide resolved
5cfe5df
to
08cffed
Compare
rebase, squash please |
Simplify the UI by removing the unimportant option |
keep it around |
Signed-off-by: Self-Hosting-Group <[email protected]>
5db970d
to
8cf41a1
Compare
Last but not least.
Any comments on this would be very welcome. |
Signed-off-by: Self-Hosting-Group <[email protected]>
8cf41a1
to
cf9dee3
Compare
Signed-off-by: Self-Hosting-Group <[email protected]>
cf9dee3
to
737751b
Compare
Signed-off-by: Self-Hosting-Group <[email protected]>
737751b
to
6c24d23
Compare
In so doing we orphan a bunch of already good i18n, with no obvious improvement. Just seems synonymous.
They're more or less synonyms. Either.
?? |
Signed-off-by: Self-Hosting-Group <[email protected]>
6c24d23
to
3d5ee2d
Compare
Signed-off-by: Self-Hosting-Group <[email protected]>
3d5ee2d
to
27e77ad
Compare
Signed-off-by: Self-Hosting-Group <[email protected]>
27e77ad
to
fbe7a35
Compare
So, you've tested these changes in situ, correct? What happens when you edit an ACL, delete one of the port fields, and press save? |
s.taboption('setup', form.Flag, 'enable_upnp', _('Enable UPnP IGD protocol')).default = '1' | ||
s.taboption('setup', form.Flag, 'enable_natpmp', _('Enable PCP/NAT-PMP protocols')).default = '1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
terminate every expression with ;
(same for all remaining lines in this file)
Signed-off-by: Self-Hosting-Group <[email protected]>
Signed-off-by: Self-Hosting-Group <[email protected]>
fbe7a35
to
8a7edac
Compare
8a7edac
to
a87f3ca
Compare
Add missing protocol term in status/overview UI and shorten menu option to
UPnP IGD & PCP
, otherwise two lines, rearrange table columns, improve wording and add help texts and note upstream change miniupnp/miniupnp@9339f0eclean_ruleset_interval/threshold
UI options as not workingThis PR completes committed changes #6863 (merged in #6975) and continues #7217 for the UPnP IGD & PCP/NAT-PMP autonomous port mapping service.
Service setup UI:
Screenshot 23.05 release
Advanced settings UI:
Screenshot 23.05 release
ACL entry UI:
Status/overview UI:
The Port Control Protocol (PCP) is the successor to NAT-PMP, has similar protocol concepts and packet formats, but adds support for IPv6 port maps and options/extensions. For more information, see:
Port Mapping Protocols Overview and Comparison 2024 - About UPnP IGD & PCP/NAT-PMP
https://github.com/Self-Hosting-Group/wiki/wiki/Port-Mapping-Protocols-Overview
Maintainer: @jow-