-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Feat/versioning #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
Is it ready to merge?
@lukasjhan not yet |
@lukasjhan since I am not getting the results I want with lerna, I will try to migrate to NX which seems to be more up to date how to handle monorepos. |
@cre8 The direction of change seems to be good, but what part is not working well? |
The continuous deployment is not working. Lerna has the call to generate the changelog and the updated version in the package jsons. But I found no good way to push these changes to the GitHub branch inside the GitHub action. I also found no documentation on the Lerna website. Three options:
I already tested the switch to nx and it was done in 10 minutes. I will evaluate all three options today so we merge this PR successful |
I'll put sd-jwt-vc PR after this :) |
@lukasjhan I updated this entry so it can be reviewed again by you :) |
I am not sure if the publish step will work at this point because I cannot check if we have all the required variables and secrets set |
Okay :) I'm reviewing right now. |
I will fix the the DCO check by resigning in an hour. |
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Lukas <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
626d4da
to
62e6428
Compare
@lukasjhan done, an hour is relative :D |
All notable changes to this project will be documented in this file. | ||
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. | ||
|
||
## [2.0.3](https://github.com/openwallet-foundation-labs/sd-jwt-js/compare/v2.0.2...v2.0.3) (2024-02-20) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this changelog generated automatically, is it right?
It might be needed to fix manually as we discuss in #44. To 0.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove the generated one from this PR. As mentioned above, I don't know what's the best way to generate the changelog that should be part of the github repo. It should be relatively easy to use the release mechanism of github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cre8 I think we might need to reset all the tags in this repo when we deploy to @sd-jwt/*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess release mechanism of github is easiest way :D.
Signed-off-by: Mirko Mollik <[email protected]> Signed-off-by: Lukas.J.Han <[email protected]> Signed-off-by: Lukas <[email protected]> Co-authored-by: Mirko Mollik <[email protected]> Co-authored-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]> Signed-off-by: Lukas.J.Han <[email protected]> Signed-off-by: Lukas <[email protected]> Co-authored-by: Mirko Mollik <[email protected]> Co-authored-by: Lukas.J.Han <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Update of this PR:
vitest usage: vitest was configured for workspace usage. This will generate a coverage report for all files (open todos: publish result file to codecoverage for better inspection. We need to set a token as a secret).
adding lint: to improve code quality lint was added. But for not it is outcomment during the ci since it would not pass ;)
optimized ci: I used veramos one as a reference. It will build and test the code. It will also publish the code to NPM when it is on one of the specific branches
Signed-off-by: Mirko Mollik [email protected]