fix: verify status list and fixes #1872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
changed the title
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
berendsliedrecht
approved these changes
Jun 4, 2024
packages/core/src/modules/sd-jwt-vc/__tests__/SdJwtVcService.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
force-pushed
the
feat/sd-jwt-revocation-verification
branch
from
a2e36e7
to
9c0f46b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds verification of
statusin an SD-JWT. Issuance will be added in a follow up PR.I also discovered that a lot of validations required by SD-JWT VC were not done since we moved to the OWF SD-JWT implementation. that library doesn't validate the payload really, whether it's expired, etc... I opened openwallet-foundation/sd-jwt-js#236 in Sd-JWT library. It seems they mainly focus on SD-JWT (not SD-JWT VC).
We also didn't have any negative tests that covered this -- so also added a bunch of new tests to handle these cases.
@berendsliedrecht Maybe you can do a pass at SD-JWT VC library soon (maybe in combination with openwallet-foundation/sd-jwt-js#83 and openwallet-foundation/sd-jwt-js#227) to make the validation in SD-JWT a bit more robust?