U4X-267 : The function to delete or remove packaging unit entries is not working #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
slubwama
changed the title
jabahum
changed the title
|
@jabahum Please resolve the conflicts. Thanks |
makombe
reviewed
Dec 18, 2023
Comment on lines
121
to
123
| title: `Delete packing item `, | ||
| kind: "success", | ||
| description: `Stock Item packing unit deleted Successfully`, |
Comment on lines
128
to
185
| title: `Error Deleting a stock item packing unit`, | ||
| kind: "error", |
There was a problem hiding this comment.
Same here translation of texts will be nice to have. This will come in handy for other implementers
…entries is not working ## Requirements - [ ] This PR has a title that briefly describes the work done including a [conventional commit](https://o3-dev.docs.openmrs.org/#/getting_started/contributing?id=your-pr-title-should-indicate-the-type-of-change-it-is) type prefix and a Jira ticket number if applicable. See existing PR titles for inspiration. #### For changes to apps - [ ] My work conforms to the [**OpenMRS 3.0 Styleguide**](https://om.rs/styleguide) and [**design documentation**](https://zeroheight.com/23a080e38/p/880723-introduction). #### If applicable - [ ] My work includes tests or is validated by existing tests. ## Summary <!-- Please describe what problems your PR addresses. --> <!-- *None* --> ## Screenshots <!-- Required if you are making UI changes. --> <!-- *None* --> ## Related Issue <!-- Paste the link to the Jira ticket here if one exists. --> <!-- https://issues.openmrs.org/browse/O3- --> <!-- *None* --> ## Other <!-- Anything not covered above --> <!-- *None* -->
jabahum
force-pushed
the
ft/The-function-to-delete-or-remove-packaging-unit-entries-is-not-working
branch
from
1007e3e
to
ab76d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Screenshots
Related Issue
https://metsprogramme.atlassian.net/browse/U4X-267
Other