Adding metrics widgets to metrics extension slot(WIP) #183
+202
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @arodidev for this, perhaps instead of test you could use something like common or template so that people get that it is to be used as a starter. Otherwise LGTM
| @@ -0,0 +1,23 @@ | |||
| import React from 'react'; | |||
| import { Tile, Layer } from '@carbon/react'; | |||
| import styles from './home-metrics-widget.scss'; | |||
There was a problem hiding this comment.
You can seperate the styles or have a single file that will insinuate that its used by many files
arodidev
changed the title
raghavawasthi24
suggested changes
Mar 10, 2024
packages/esm-home-app/src/homepage-metrics/TestDataTile.component.tsx
Outdated
Show resolved
Hide resolved
pirupius
reviewed
Mar 20, 2024
Comment on lines
+9
to
+11
| const { data: appointmentsData } = useAppointmentsData(); | ||
| const { data: activeVisitsData } = useActiveVisits(); | ||
| const { data: visitSummaryData } = useVisitSummary(); |
There was a problem hiding this comment.
These don't belong here. esm-home should just set up the slot and the logic should live in the respective esms similar to the way the appointments widget is lives in the appointments esm but is attached to the home dashboard slot
pirupius
reviewed
Mar 20, 2024
| @@ -19,6 +19,7 @@ export default function HomeDashboard() { | |||
| return ( | |||
| <section className={isDesktop(layout) && styles.dashboardContainer}> | |||
| {isDesktop(layout) && <ExtensionSlot name="home-sidebar-slot" key={layout} />} | |||
| <ExtensionSlot className={styles.homeMetricsWidgets} name="home-metrics-widgets-slot" /> | |||
There was a problem hiding this comment.
This should also be moved to the DashboardView
|
@arodidev ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
None.
Related Issue
None.
Other
None.