(chore) Bump form engine lib #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usamaidrsk
requested review from
samuelmale and
denniskigen
and removed request for
samuelmale
usamaidrsk
force-pushed
the
ch-up-form-engine-lib
branch
from
313754b
to
dd7a1de
Compare
samuelmale
reviewed
Oct 24, 2024
| @@ -143,7 +142,7 @@ const FormEditorContent: React.FC<TranslationFnProps> = ({ t }) => { | |||
| }; | |||
|
|
|||
| const inputDummySchema = useCallback(() => { | |||
| const dummySchema: FormSchema = { | |||
| const dummySchema: typeof schema = { | |||
There was a problem hiding this comment.
@usamaidrsk Is this related to the bump?
There was a problem hiding this comment.
Looking again here, I think I will need to use exported types from the lib i.e , I had added that to fix some type errors after the bump.
Thanks
There was a problem hiding this comment.
I think its just that the type label was made optional in the form engine, and we have to update the interface Schema in here as well to make label optional, the changes are in PR #355 but it isn't merged in yet
There was a problem hiding this comment.
Thanks for the pointer @NethmiRodrigo
I will add that to this PR as the other looks to bring in more changes to wait for it.
usamaidrsk
force-pushed
the
ch-up-form-engine-lib
branch
from
dd7a1de
to
ccccb7d
Compare
denniskigen
approved these changes
Oct 25, 2024
NethmiRodrigo
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR bumps the form-engine-lib to the latest available version
Screenshots
Related Issue
Other