(feat) O3-3947: Add support for different question types #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…well as options for the toggle
This change introduces the ability for form questions to utilize Markdown formatting. A new Markdown input field is added to the question editor, allowing users to specify Markdown content. This content is then rendered appropriately when the form is displayed.
Added a new configuration option to enable a Markdown editor for text input.
Introduces the ability for form creators to utilize Markdown formatting in question text, providing greater flexibility and control over question presentation.
When editing a "content-switcher" question type, the available answers are now dynamically populated based on the selected concept. This ensures that users can only choose from relevant answers associated with the chosen concept, streamlining the question editing process.
Introduces the capability to configure and launch workspaces directly from the question builder interface. This enhancement provides users with a streamlined method to initiate workspaces, enhancing the platform's interactive capabilities.
This introduces UI elements specifically for the "workspace-launcher" question type. Users can now input a button label and a workspace name when editing a question of this type.
NethmiRodrigo
changed the title
|
@Kinotijoan can you resolve the merge conflicts and update your fork? |
|
For questions of type |
sure |
Removes the option to customize labels for the "true" and "false" states of toggle fields.
Standardizes the casing of "On" and "Off" labels used within the toggle component in the English translation file to ensure consistency throughout the application. This addresses a minor visual discrepancy and enhances the overall user experience.
NethmiRodrigo
requested changes
Oct 21, 2024
Comment on lines
+540
to
+541
| id="lableTrue" | ||
| labelText={t('Label true', 'Label true')} |
There was a problem hiding this comment.
Suggested change
| id="lableTrue" | |
| labelText={t('Label true', 'Label true')} | |
| id="labelTrue" | |
| labelText={t('labelTrue', 'Label true')} |
| value={t(toggleLabelTrue || '')} | ||
| onChange={(event: React.ChangeEvent<HTMLInputElement>) => | ||
| setToggleLabelTrue(event.target.value) | ||
| } | ||
| placeholder={t('on', 'On')} | ||
| placeholder={t('On')} |
There was a problem hiding this comment.
Suggested change
| placeholder={t('On')} | |
| placeholder={t('on', 'On')} |
Comment on lines
+550
to
+551
| id="lableFalse" | ||
| labelText={t('Label false', 'Label false')} |
There was a problem hiding this comment.
Suggested change
| id="lableFalse" | |
| labelText={t('Label false', 'Label false')} | |
| id="labelFalse" | |
| labelText={t('labelFalse', 'Label false')} |
| value={t(toggleLabelFalse || '')} | ||
| onChange={(event: React.ChangeEvent<HTMLInputElement>) => | ||
| setToggleLabelFalse(event.target.value) | ||
| } | ||
| placeholder={t('off', 'Off')} | ||
| placeholder={t('Off')} |
There was a problem hiding this comment.
Suggested change
| placeholder={t('Off')} | |
| placeholder={t('off', 'Off')} |
Comment on lines
+765
to
+775
| {renderingType == 'markdown' ? ( | ||
| <TextInput | ||
| id="questionMarkdown" | ||
| labelText={t('questionMarkdown', 'Markdown')} | ||
| placeholder={t('questionMarkdownPlaceholder', 'Enter the Markdown for your form...')} | ||
| value={formMarkdown} | ||
| onChange={(event: React.ChangeEvent<HTMLInputElement>) => | ||
| setFormMarkdown(event.target.value.split(',').map((item) => item.trim())) | ||
| } | ||
| /> | ||
| ) : null} |
There was a problem hiding this comment.
I don't think we need this since PR #355 will implement this
Comment on lines
+665
to
+675
| {fieldType == 'markdown' ? ( | ||
| <TextInput | ||
| id="questionMarkdown" | ||
| labelText={t('questionMarkdown', 'Markdown')} | ||
| placeholder={t('questionMarkdownPlaceholder', 'Enter the Markdown for your form...')} | ||
| value={formMarkdown} | ||
| onChange={(event: React.ChangeEvent<HTMLInputElement>) => | ||
| setFormMarkdown(event.target.value.split(',').map((item) => item.trim())) | ||
| } | ||
| /> | ||
| ) : null} |
There was a problem hiding this comment.
Same as above, won't be needed
Comment on lines
+152
to
+153
| const [toggleLabelTrue, setToggleLabelTrue] = useState(''); | ||
| const [toggleLabelFalse, setToggleLabelFalse] = useState(''); |
There was a problem hiding this comment.
This should be reverted
Comment on lines
+155
to
+156
| const [buttonLabel, setButtonLabel] = useState(''); | ||
| const [workspaceName, setWorkspaceName] = useState(''); |
There was a problem hiding this comment.
These variables should be initiated not with an empty string but with the relevant values from the questionToEdit object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
I have added support for some question types that were in the json-schema but not in the interactive builder hence I have finalised on this ticket
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3947
Other