Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostport network not ready when no ports exist #100

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

chrisliu1995
Copy link
Member

No description provided.

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furykerry for approval by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

Codecov Report

Merging #100 (5ac4d64) into master (4d003d6) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   31.32%   31.24%   -0.08%     
==========================================
  Files          19       19              
  Lines        2503     2509       +6     
==========================================
  Hits          784      784              
- Misses       1674     1680       +6     
  Partials       45       45              
Flag Coverage Δ
unittests 31.24% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cloudprovider/kubernetes/hostPort.go 8.91% <0.00%> (-0.22%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ringtail
Copy link
Member

/LGTM

@ringtail ringtail merged commit 758eb33 into openkruise:master Oct 26, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants