Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nutripatrol product report #10991

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: nutripatrol product report #10991

wants to merge 14 commits into from

Conversation

alexgarel
Copy link
Member

First Nutri-Patrol integration.

image

@alexgarel alexgarel requested a review from a team as a code owner November 7, 2024 14:11
@github-actions github-actions bot added 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Products 🌐 Translations labels Nov 7, 2024
@alexgarel alexgarel changed the title Feat nutripatrol product report feat: nutripatrol product report Nov 7, 2024
@alexgarel
Copy link
Member Author

/update_tests_results

@github-actions github-actions bot added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧪 tests 🧪 integration tests labels Nov 7, 2024
@alexgarel
Copy link
Member Author

/update_tests_results

@stephanegigandet
Copy link
Contributor

/update_tests_results

@alexgarel
Copy link
Member Author

/lint

@alexgarel
Copy link
Member Author

/update_tests_results

stephanegigandet
stephanegigandet approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

stephanegigandet
stephanegigandet reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexgarel I was surprised that the integration test expected files were not changed, I think it may be due to the fact that the environment file used in tests doesn't have the NUTRIPATROL_URL.

Shouldn't it be added to https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.env ?

@alexgarel
Copy link
Member Author

/update_tests_results

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alexgarel
Copy link
Member Author

@teolemon, @Valimp and @g123k this PR adds a new action "report_product_to_nutripatrol" to knowledge panels, which is not yet implemented in the mobile app.

Is it ok, or should I only display the panel for the web ?

stephanegigandet
stephanegigandet approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks @alexgarel

@alexgarel
Copy link
Member Author

@stephanegigandet we don't merge immediately, we need to hide the panel for mobile until they implement the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@alexgarel alexgarel

Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧪 integration tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 👮 Moderation multilingual products Products Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests 🌐 Translations
Projects
📖 Knowledge panels
Status: Reviewer approved
🛠️ - Server - API
Status: Reviewer approved
🛡️ Nutri-Patrol
Status: Ready
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgarel @stephanegigandet @teolemon